src/README	368820	[ +2 -0 ]	diff (colored)
src/README.md	368820	[ +2 -0 ]	diff (colored)

Mark the repository as being converted to Git.

This is the last Subversion commit to src.

Sponsored by:	The FreeBSD Foundation

src/share/man/man4/tcp.4	368819	[ +16 -1 ]	diff (colored)
src/sys/netinet/in_pcb.c	368819	[ +92 -20 ]	diff (colored)
src/sys/netinet/in_pcb.h	368819	[ +2 -1 ]	diff (colored)
src/sys/netinet/tcp.h	368819	[ +4 -0 ]	diff (colored)
src/sys/netinet/tcp_usrreq.c	368819	[ +10 -0 ]	diff (colored)
src/sys/netinet6/in6_pcb.c	368819	[ +25 -12 ]	diff (colored)
src/sys/netinet6/in6_pcb.h	368819	[ +1 -1 ]	diff (colored)

Filter TCP connections to SO_REUSEPORT_LB listen sockets by NUMA domain

In order to efficiently serve web traffic on a NUMA
machine, one must avoid as many NUMA domain crossings as
possible. With SO_REUSEPORT_LB, a number of workers can share a
listen socket. However, even if a worker sets affinity to a core
or set of cores on a NUMA domain, it will receive connections
associated with all NUMA domains in the system. This will lead to
cross-domain traffic when the server writes to the socket or
calls sendfile(), and memory is allocated on the server's local
NUMA node, but transmitted on the NUMA node associated with the
TCP connection. Similarly, when the server reads from the socket,
he will likely be reading memory allocated on the NUMA domain
associated with the TCP connection.

This change provides a new socket ioctl, TCP_REUSPORT_LB_NUMA. A
server can now tell the kernel to filter traffic so that only
incoming connections associated with the desired NUMA domain are
given to the server. (Of course, in the case where there are no
servers sharing the listen socket on some domain, then as a
fallback, traffic will be hashed as normal to all servers sharing
the listen socket regardless of domain). This allows a server to
deal only with traffic that is local to its NUMA domain, and
avoids cross-domain traffic in most cases.

This patch, and a corresponding small patch to nginx to use
TCP_REUSPORT_LB_NUMA allows us to serve 190Gb/s of kTLS encrypted
https media content from dual-socket Xeons with only 13% (as
measured by pcm.x) cross domain traffic on the memory controller.

Reviewed by:	jhb, bz (earlier version), bcr (man page)
Tested by: gonzo
Sponsored by:	Netfix
Differential Revision:	https://reviews.freebsd.org/D21636

src/sys/kern/uipc_ktls.c

368818

[ +39 -3 ]

diff (colored)

Optionally bind ktls threads to NUMA domains

When ktls_bind_thread is 2, we pick a ktls worker thread that is
bound to the same domain as the TCP connection associated with
the socket. We use roughly the same code as netinet/tcp_hpts.c to
do this. This allows crypto to run on the same domain as the TCP
connection is associated with. Assuming TCP_REUSPORT_LB_NUMA
(D21636) is in place & in use, this ensures that the crypto source
and destination buffers are local to the same NUMA domain as we're
running crypto on.

This change (when TCP_REUSPORT_LB_NUMA, D21636, is used) reduces
cross-domain traffic from over 37% down to about 13% as measured
by pcm.x on a dual-socket Xeon using nginx and a Netflix workload.

Reviewed by:	jhb
Sponsored by:	Netflix
Differential Revision:	https://reviews.freebsd.org/D21648

src/lib/libc/locale/setlocale.3	368817	[ +9 -9 ]	diff (colored)
src/lib/libc/net/gethostbyname.3	368817	[ +20 -20 ]	diff (colored)
src/lib/libc/stdlib/system.3	368817	[ +1 -1 ]	diff (colored)
src/lib/libc/sys/_umtx_op.2	368817	[ +2 -2 ]	diff (colored)
src/lib/libc/sys/copy_file_range.2	368817	[ +3 -7 ]	diff (colored)
src/lib/libc/sys/execve.2	368817	[ +1 -1 ]	diff (colored)
src/lib/libc/sys/fhlink.2	368817	[ +2 -2 ]	diff (colored)
src/lib/libc/sys/open.2	368817	[ +1 -1 ]	diff (colored)
src/lib/libc/sys/pdfork.2	368817	[ +1 -1 ]	diff (colored)
src/lib/libc/sys/ptrace.2	368817	[ +6 -8 ]	diff (colored)
src/lib/libc/sys/revoke.2	368817	[ +1 -1 ]	diff (colored)
src/lib/libc/sys/rtprio.2	368817	[ +4 -1 ]	diff (colored)
src/lib/libc/sys/sendfile.2	368817	[ +4 -4 ]	diff (colored)
src/lib/libc/sys/thr_exit.2	368817	[ +1 -1 ]	diff (colored)
src/lib/libc/sys/thr_new.2	368817	[ +1 -1 ]	diff (colored)
src/lib/libc/sys/thr_self.2	368817	[ +1 -1 ]	diff (colored)
src/lib/libc/sys/thr_set_name.2	368817	[ +1 -1 ]	diff (colored)
src/lib/libc/sys/thr_suspend.2	368817	[ +0 -1 ]	diff (colored)
src/lib/libc/sys/thr_wake.2	368817	[ +1 -1 ]	diff (colored)
src/lib/libc/x86/sys/pkru.3	368817	[ +1 -1 ]	diff (colored)

libc: Fix most issues reported by mandoc

- varios "new sentence, new line" warnings
- varios "sections out of conventional order" warnings
- varios "unusual Xr order" warnings
- varios "missing section argument" warnings
- varios "no blank before trailing delimiter" warnings
- varios "normalizing date format" warnings

MFC after:	1 month

src/usr.sbin/trim/trim.8

368816

[ +7 -5 ]

diff (colored)

trim(8): Fix a few issues reported by mandoc

- new sentence, new line
- unusual Xr order: ioctl(2) after da(4)
- unusual Xr order: sysexits(3) after nda(4)

MFC after:	1 week

src/usr.sbin/zonectl/zonectl.8

368815

[ +1 -7 ]

diff (colored)

zonectl(8): Fix a few issues reported by mandoc

- Add missing quotation mark for a comment above the .Dd
- inserting missing end of block: Sh breaks Bd
- skipping paragraph macro: Pp before Bl
- skipping paragraph macro: Pp before Bd
- empty block: Bd

MFC after:	1 week

src/usr.sbin/nfsd/nfsv4.4

368814

[ +7 -5 ]

diff (colored)

nfsv4(4): Fix a few issues reported by mandoc

- new sentence, new line
- function name without markup: rtalloc()
- function name without markup: VOP_RECLAIM()

MFC after:	1 week

src/usr.sbin/bluetooth/bluetooth-config/bluetooth-config.8	368813	[ +10 -8 ]	diff (colored)
src/usr.sbin/bluetooth/hccontrol/hccontrol.8	368813	[ +4 -5 ]	diff (colored)
src/usr.sbin/bluetooth/hcseriald/hcseriald.8	368813	[ +1 -1 ]	diff (colored)
src/usr.sbin/bluetooth/sdpd/sdpd.8	368813	[ +10 -10 ]	diff (colored)

bluetooth: Fix a mandoc related issues

- new sentence, new line
- sections out of conventional order: Sh FILES
- unusual Xr order: bthost(1) after bthidd(8)
- no blank before trailing delimiter
- whitespace at end of input line
- sections out of conventional order: Sh EXIT STATUS

MFC after:	1 week

src/usr.sbin/mpsutil/mpsutil.8

368812

[ +1 -1 ]

diff (colored)

mpsutil(8): Remove trailing whitespace

MFC after:	1 week

src/usr.sbin/bhyvectl/bhyvectl.8

368811

[ +1 -1 ]

diff (colored)

bhyvectl(8): Normalize the man page date

MFC after:	1 week

src/usr.sbin/camdd/camdd.8

368810

[ +1 -1 ]

diff (colored)

camdd(8): Fix the man page date

The comment before the .Dd macro was missing a quotation mark, so that
the date of the man page was always today.

MFC after:	3 days

src/usr.sbin/config/config.5	368809	[ +7 -7 ]	diff (colored)
src/usr.sbin/config/config.8	368809	[ +4 -3 ]	diff (colored)

config: Fix a few mandoc related errors

- new sentence, new line
- no blank before trailing delimiter

MFC after:	1 week

src/usr.sbin/devctl/devctl.8

368808

[ +5 -5 ]

diff (colored)

devctl(8): Correct "sections out of conventional order" error

MFC after:	1 week

src/usr.bin/patch/patch.1

368807

[ +6 -6 ]

diff (colored)

patch(1): Fix a few mandoc related issues

- no blank before trailing delimiter

MFC after:	1 week

src/usr.bin/uname/uname.1

368806

[ +1 -1 ]

diff (colored)

uname(1): Fix a typo in the man page date

MFC after:	3 days

src/usr.bin/ident/ident.1

368805

[ +1 -1 ]

diff (colored)

ident(1): Normalizing date format

MFC after:	3 days

src/sbin/ipfw/ipfw.8

368804

[ +50 -48 ]

diff (colored)

ipfw(8): Fix a few mandoc related issues

- no blank before trailing delimiter
- missing section argument: Xr inet_pton
- skipping paragraph macro: Pp before Ss
- unusual Xr order: syslogd after sysrc
- tab in filled text

There were a few multiline NAT examples which used the .Dl macro with
tabs. I converted them to .Bd, which is a more suitable macro for that case.

MFC after:	1 week

src/sbin/ping/ping.8

368803

[ +1 -1 ]

diff (colored)

ping(8): Fix a mandoc related issue

- unusual Xr punctuation: none before traceroute6(8)

src/sbin/nvmecontrol/nvmecontrol.8

368802

[ +9 -5 ]

diff (colored)

nvmecontrol(8): Fix a few mandoc related issues and add a SEE ALSO section

- inserting missing end of block: Ss breaks Bl
- skipping paragraph macro: Pp before Ss
- referenced manual not found: Xr nvme 4 (2 times)
- unknown standard specifier: St The

The macro .St can only be used for standards known by mdoc(7). So add a
SEE ALSO section and add a reference to the NVM Express Base Specification.

MFC after:	2 weeks

src/sys/dev/usb/net/if_ure.c

368801

[ +1 -1 ]

diff (colored)

Ensure a minimum packet length before creating a mbuf in if_ure.

Sponsored by:	Mellanox Technologies // NVIDIA Networking

src/sbin/devd/devd.conf.5

368800

[ +3 -3 ]

diff (colored)

devd.conf(5): Fix a mandoc related issue

- sections out of conventional order: Sh SEE ALSO

MFC after:	1 week

src/sys/dev/usb/net/if_ure.c

368799

[ +9 -9 ]

diff (colored)

Move SYSCTL_ADD_PROC() to unlocked context in if_ure to avoid lock order reversal.

MFC after:	1 week
Reported by:	Mark Millard <marklmi@yahoo.com>
Sponsored by:	Mellanox Technologies // NVIDIA Networking

src/share/man/man9/sysctl.9

368798

[ +2 -2 ]

diff (colored)

sysctl(9): Fix a few mandoc related issues

- missing comma before name: Nm SYSCTL_UQUAD
- bad NAME section content: text

MFC after:	1 week

src/share/man/man9/ofw_bus_status_okay.9

368797

[ +2 -3 ]

diff (colored)

ofw_bus_status_okay(9): Fix a few mandoc related issues

- missing comma before name: Nm ofw_bus_status_okay
- missing comma before name: Nm ofw_bus_node_status_okay
- skipping paragraph macro: Pp after Sh

MFC after:	1 week

src/share/man/man9/ofw_bus_is_compatible.9

368796

[ +3 -4 ]

diff (colored)

ofw_bus_is_compatible(9): Fix a few mandoc related issues

- missing comma before name: Nm ofw_bus_is_compatible_strict
- missing comma before name: Nm ofw_bus_node_is_compatible
- missing comma before name: Nm ofw_bus_search_compatible
- skipping paragraph macro: Pp after Sh

MFC after:	1 week

src/share/man/man9/fail.9

368795

[ +9 -3 ]

diff (colored)

fail(9): Fix a few mandoc related issues

- function name without markup: return()
- function name without markup: print()

MFC after:	1 week

src/share/man/man9/driver.9

368794

[ +5 -5 ]

diff (colored)

driver(9): Fix a mandoc related issue

- sections out of conventional order: Sh SEE ALSO

MFC after:	1 week

src/share/man/man9/bhnd_erom.9

368793

[ +2 -5 ]

diff (colored)

bhnd_erom(9): Fix a few mandoc related issues

- skipping paragraph macro: Pp before Bl
- skipping paragraph macro: Pp after Ss
- skipping paragraph macro: Pp at the end of Ss
- unusual Xr punctuation: none before bhnd_driver_get_erom_class(9)
- unusual Xr punctuation: none before bus_space(9)

MFC after:	1 week

src/share/man/man9/bhnd.9

368792

[ +3 -18 ]

diff (colored)

bhnd(9): Fix a few mandoc related issues

- skipping paragraph macro: Pp before Bl
- skipping paragraph macro: Pp at the end of Ss
- missing section argument: Xr device_set_desc
- unusual Xr punctuation: none before bhnd_erom(9)

MFC after:	1 week

src/share/man/man9/disk.9

368791

[ +7 -6 ]

diff (colored)

disk(9): Fix a few mandoc related errors

- function name without markup: g_io_deliver()
- function name without markup: disk_gone()
- sections out of conventional order: Sh SEE ALSO
- referenced manual not found: Xr MAKE_DEV 9

Actually the man page of MAKE_DEV has never existed.

MFC after:	3 days