Comments for Plataforma Tecnologia Blog

Comment on Show your objects baby! by Rafael Rosa

Rafael Rosa — Wed, 10 Mar 2010 21:10:20 +0000

Hi,

@Nando is right, the DL, DT and DD tags are the recommended ones for this job, label is exclusive for form. My bad

http://www.w3.org/TR/html5/semantics.html#the-dl-element

The styling may be a little trick, but perhaps it worth the trouble to define a correct default.

Regards

Comment on Show your objects baby! by José Valim

José Valim — Wed, 10 Mar 2010 21:02:21 +0000

Agreed, label is def. not the recommended one. First show_for versions used b tags instead of strong. And then I got a few pull requests asking to change to strong. Good news is, it’s easy to customize in your app.

@BillSaysThis I’m investigating.

Comment on Show your objects baby! by Nando Vieira

Nando Vieira — Wed, 10 Mar 2010 20:58:43 +0000

@Rafael and @Alvaro: even the label tag isn’t the recommend one. The label is meant to be associated with a form element.
I think DL can be used, but is not that easy to style it. I’d probably go with p > strong + text.

Comment on Show your objects baby! by BillSaysThis

BillSaysThis — Wed, 10 Mar 2010 20:31:09 +0000

I’m getting a generator not found (using latest Rails 3):

wgd1 root# gem install show_for
Successfully installed show_for-0.2.0
1 gem installed
Installing ri documentation for show_for-0.2.0…
Updating class cache with 4063 classes…
Installing RDoc documentation for show_for-0.2.0…

wgd1$ rails generate show_for_install
Could not find generator show_for_install.
wgd1$ rails g
Please choose a generator below.
Rails:
… as expected
ActiveRecord:
… as expected
Erb:
… as expected
Rspec:
… as expected
TestUnit:
… as expected

Comment on Show your objects baby! by Carlos Antônio

Carlos Antônio — Wed, 10 Mar 2010 20:28:58 +0000

@Rafael really thanks for the tips. And we are going to take a look at the markup inside the comments ..

@Rafael and @Alvaro, the initializer ShowFor installs inside your config/initializers has some configurations that allows you to change each piece of code it uses, for instance the label_tag, wrapper_tag, and default separator (ie br tag). Perhaps I missed explaining a bit about it in the post.
I think it should do the trick of overriding the :strong tag for :label for instance. Anyway, I agree label is “the name/title of the thing ahead” (I liked it =D).

@Alvaro a patch to add :attributes would be appreciated =). Thanks.

Comment on Show your objects baby! by Alvaro Pereyra (Yaraher)

Alvaro Pereyra (Yaraher) — Wed, 10 Mar 2010 20:12:57 +0000

I’d agree with Rafael’s comment. Why use strong instead of the proper (and dare I say, semantic) “label” tag?.

Besides that, I like a lot. Feels “formtasticly” in spirit. Great work!

What about adding a attributes method? So your first example would become something like (using HAML to try to evade that markup eating of wordpress ):

show_for @person do |p|
= p.attributes :first_name, :last_name, :confirmed?
= p.attribute :created_at, :format => :short
= p.attribute :age, :if_blank => “No age”