Flyspray

MCPuk file browser files on UTF-8 filesystems

Sat, 27 Sep 2008 08:27:58 -0500

When you try to browse a folder containing non ASCII characters on an UTF-8 filesystem, the browser fails to list folder contents. It seems to be related with the way entities are escaped in manager/media/browser/mcpuk/connectors/php/Commands/GetFoldersAndFiles.php line 134, there should be a way to precise (or detect) the encoding of the filesystem. Currently é is escaped as �?© which is encoded as Ã© so XML processing fails due to unknown entity © Using htmlentities($files[$i], ENT_QUOTES, 'UTF-8') does the trick but isn't flexible enough...

phpmailer + utf8 = ThunderBird subject brocken!

Fri, 04 Jul 2008 11:31:53 -0500

i has a mail`s with broken subjects.. so i read class.phpmailer.php and found - line 1168: $maxlen = 75 - 7 - strlen($this->CharSet); after i change 75 to 76 - all ok! p.s. my free time is limited - so please check it!

Creating documents without rights

Mon, 23 Jun 2008 05:17:02 -0500

I just updated to rev. 3788. It's possible to create an document in a document for which your group has no rights. So you can create new documents whereever you want. In root level that's not possible. But after creating the document you have no right on it, so you can't edit it.

After maximum login attempts need block IP, but not user account

Tue, 20 May 2008 04:15:04 -0500

I think, that in CMS Manager need option: - block user account, or - block IP for example, hacker will try to login in CMS Manager 1 time per second and account always will be block.

tv filtering -no anonymous role?

Mon, 19 May 2008 22:28:27 -0500

why there is no anonymous role? for example: i want to hide some TV from document - so i create doc group. BUT after that - this group avialable only for registered users... p.s.: assign tv for templates - not useful in this case...

makeUrl bug - after newspublisher - redirect to wrong url (no path) (UserFriendlyURL=1)

Fri, 03 Oct 2008 07:20:58 -0500

i have a bug - i use newspublisher to post a news record. clearcache =1 UserFriendlyURLs=1 so, after saving a post - makeUrl send me to wrong place! i.e. there no path (parent alias)... (i`m also patched NewsPublisher - now it`s generate alias from title) so... i patched makeUrl ... attaching code...

Document tree sort order mixed up

Sat, 27 Sep 2008 09:38:28 -0500

The sort order of the most recent versions of MODx 0.9.6x seems to use the id of the document, rather than more useful things like folder, or title, or menuindex. The sort order (for me) would be: folder,menuindex,title And ideally this would be customizable on a per user basis. A checkbox could be added to "remember this sort order" in a cookie that lasts beyond sessions. Maybe it would even be stored in a database

The comment about old/duplicaete methods in API.

Thu, 27 Mar 2008 22:12:22 -0500

I really hope the comments would be added to old/duplicate methods in API. Though I understand they are for backward compatibility, there are many old/duplicate methods. And there are some methods which I guess it would be extended/changed in the near future. For example, in DocumentParser class, I guess getExtTable***/getIntTable***() are old methods, they would be integrated in DBAPI class. And getParent() would be changed to getDocumentParent(), getPageInfo() is duplicate method of getDocument(). and more. I feel MODx is really excellent, and respect whole developers. Please, add a little comment to method which is old/duplicate one, and having plan to extend/change. And everyone will be happy, and it will be a little easy that new developers join in MODx that is a really excellent CMS/Framework.

DocumentParser::getAllChildren() and getActiveChildren need 'sort' parameter.

Thu, 27 Mar 2008 19:11:52 -0500

DocumentParser::getChildren() and getDocuments() doesn't need 'sort' parameter. But, getAllChildren() and getActiveChildren need 'sort' parameter. If we call with 'sort=""', these methods make error. I hope getChildren() and getDocuments() will be same behavior as getAllChildren() and getActiveChildren.

DocumentParse::checkCache() shows incorrect error page.

Thu, 27 Mar 2008 13:24:09 -0500

It's possible DocumentParse::checkCache() shows incorrect error page. Because '$seclimit' isn't initialized, when '$this->config['unauthorized_page']' is false. if (!$pass) { if ($this->config['unauthorized_page']) { // check if file is not public $tbldg= $this->getFullTableName("document_groups"); $secrs= $this->dbQuery("SELECT id FROM $tbldg WHERE document = '" . $id . "' LIMIT 1;"); if ($secrs) $seclimit= mysql_num_rows($secrs); } if ($seclimit > 0) { // match found but not publicly accessible, send the visitor to the unauthorized_page $this->sendUnauthorizedPage(); exit; // stop here } else { // no match found, send the visitor to the error_page $this->sendErrorPage(); exit; // stop here } }