Flyspray

tv.ajax.php corrupting URL fields

Thu, 07 Aug 2008 08:40:33 -0500

Hi, During use I noticed that when using the submitURL in a form on one of our pages the protocol dropdown would become blank (after save and reedit) and the url section would produce a $v at the beginning. I am new to the software but this might stem from a bug on line 158 of the following code: http://svn.modxcms.com/svn/tattoo/tattoo/trunk/assets/modules/docmanager/includes/tv.ajax.php Shouldn't this be: $field_html.=''.$k.''; (Note the '. .' around the $v in option value) Cheers

Duplicate content fails on mysql3

Wed, 16 Jul 2008 16:26:28 -0500

Query parser error occurs. Sinse i don't have an svn account, all i can do is to attach a fixed file (see diff for details).

phpmailer + utf8 = ThunderBird subject brocken!

Fri, 04 Jul 2008 11:31:53 -0500

i has a mail`s with broken subjects.. so i read class.phpmailer.php and found - line 1168: $maxlen = 75 - 7 - strlen($this->CharSet); after i change 75 to 76 - all ok! p.s. my free time is limited - so please check it!

Date TV breaks if minus sign in TV name

Sat, 28 Jun 2008 04:26:39 -0500

Create a TV named 'my-lovely-tv' as type Date. Edit a document using the TV. The datepicker object fails to be created. Fix: replace line 38 in manager/includes/tmplvars.inc.php with: $cal = 'cal' . str_replace('-','_',$field_name); Warning: I have no idea what other characters you might want to use in your TV names that would cause similar problems in your javascript variable names. This only fixes for '-'.

Menu indexing option in main configuration panel doesn't work for documents

Sat, 28 Jun 2008 03:08:56 -0500

Option "Menu indexing default" work as "on" for all documents even through it's switched off. Causes: This option doesn't parsed in mutate_content.dynamic.php so script think that it's always switched "on". mutate_content.dynamic.php:130 // increase menu index if this is a new document if (!isset($_REQUEST["id"])) { if (!isset($auto_menuindex) || $auto_menuindex) { $pid = intval($_REQUEST["pid"]); $tbl = $modx->getFullTableName("site_content"); $sql = "SELECT count(*) as 'cnt' FROM $tbl WHERE parent='$pid'"; $content["menuindex"] = $modx->db->getValue($sql); } else { $content['menuindex'] = 0; } } Solution: // increase menu index if this is a new document if (!isset($_REQUEST["id"])) { if (!isset($auto_menuindex) || $auto_menuindex) { $pid = intval($_REQUEST["pid"]); $tbl = $modx->getFullTableName("site_content"); $sql = "SELECT count(*) as 'cnt' FROM $tbl WHERE parent='$pid'"; $content["menuindex"] = $modx->db->getValue($sql); } else { $content['menuindex'] = 0; $content['hidemenu'] = 1; } }

DataGrid incorrect renders TVs

Sat, 28 Jun 2008 03:00:18 -0500

DataGrid widget renders TVs as shown in attach. Cause: TV must be divided into rows, but it isn't happen. That's datagrid.class use every element (symbol) of TV as row, and make table with only one column datagrid.class.php:175 $this->_colcount = count($this->_colnames); $tblColHdr =""; Solution: $this->_colcount = count($this->_colnames); if(!$this->_isDataset) { $this->ds = explode((strstr($this->ds,"||")!==false ? "||":","),$this->ds); $this->ds = array_chunk($this->ds, $this->_colcount); } $tblColHdr ="";

Copying of a template doesn't copy template variable associations

Tue, 24 Jun 2008 04:00:44 -0500

Like in title; when you duplicate a template, the associated TV's are not copied with it which is pretty annoying when you have a lot of associated TVs. You have to manually reconnect them all.

Creating documents without rights

Mon, 23 Jun 2008 05:17:02 -0500

I just updated to rev. 3788. It's possible to create an document in a document for which your group has no rights. So you can create new documents whereever you want. In root level that's not possible. But after creating the document you have no right on it, so you can't edit it.

Mistake inside tinymce.lang.php

Wed, 18 Jun 2008 01:44:32 -0500

http://svn.modxcms.com/svn/tattoo/tattoo/trunk/assets/plugins/tinymce303/tinymce.lang.php string $tinyLang[] = array("russion-UTF8","ru"); have to change to $tinyLang[] = array("russian-UTF8","ru");

meta appears in wrong place in header message

Wed, 11 Jun 2008 10:47:57 -0500

as i said in title, the meta are inserted before the page title in the generated html code. that s a problem for google bot and others. it would be great to take care of that here is a sample code from my modx site : Candidature - ###